Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the use of workspaceFolder without specifying workspaceMount #4

Open
Chuxel opened this issue Jan 21, 2022 · 1 comment
Open
Labels
proposal Still under discussion, collecting feedback

Comments

@Chuxel
Copy link
Member

Chuxel commented Jan 21, 2022

Today the workspaceFolder property requires workspaceMount to be in non-dockerCompose scenarios. Given processing for devcontainer.json should mount the location of the .git folder unless workspaceMount is set, it is reasonable to allow this property to be set independently.

In this scenario, the following syntax could be used to connect to a relative path to the detected auto-mount location.

"workspaceFolder": "${containerWorkspaceFolder}/some/sub/path" 

To avoid confusion, if workspaceMount is specified, or this is a Docker Compose scenario, ${containerWorkspaceFolder} would be treated like "". We could also introduce a different variable here instead (e.g. defaultContainerWorkspaceFolder) that had these same smarts in it.

@Chuxel Chuxel added the proposal Still under discussion, collecting feedback label Jan 21, 2022
@Santiagosaiz
Copy link

@Santiagosaiz4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal Still under discussion, collecting feedback
Projects
None yet
Development

No branches or pull requests

2 participants