-
-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make FontAwesome clickable #127
Comments
This is my current solution:
Is there a cleaner, more elegant solution? |
The problem is that all icons get the function and there is no default page, such that you get error 404 if you do not set url in the YAML. I have actually the probelm with the see_more parameter: the text becomes a link to a different page set for another icon ?? |
Just need to add a check to the partial injection then that will go
with |
Ok got it to work, the problem was that the href tag was not closed and the link was given to all text following. Here is the workaround: modify the feature.html like this (line12-18 to change to):
|
@jcolomb fancy making a pull request for that? |
I do ! |
go ahead and we'll review it @jcolomb |
see |
or see my comment about a (slightly different) approach |
bumping this for review - i would really like this to be implemented. |
I'm closing this issue because #184 implements the feature clicklable. |
Is it possible to add a link to icons in Features and make FontAwesome icons clickable?
The text was updated successfully, but these errors were encountered: