Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug/Feature Request] Resize Event Listener not appropriate when container option not window #51

Open
haxxxton opened this issue May 23, 2017 · 1 comment
Open

[Bug/Feature Request] Resize Event Listener not appropriate when container option not window #51

haxxxton opened this issue May 23, 2017 · 1 comment

Comments

@haxxxton
Copy link
Contributor

Currently VirtualList attaches to the 'resize' event on the supplied container option.

This is fine when window is supplied as the container, but will not fire when an alternate element is supplied.

There are a number of approaches for detecting element size change of non-window elements that could be integrated to correctly trigger this.refreshState.

Happy to submit a PR if you wanted to choose which lib you liked best.
@haxxxton haxxxton changed the title [Bug/Feature Request] Resize Event Listener not appropriate when container option specified [Bug/Feature Request] Resize Event Listener not appropriate when container option not window May 23, 2017
@developerdizzle
Copy link
Owner

Personally, I think the ResizeObserver pattern with a note about requiring a polyfill would be best.

@mmontag mmontag mentioned this issue May 19, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@haxxxton @developerdizzle