Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase: Add worker-loader #867

Merged
merged 10 commits into from Oct 6, 2021
Merged

Rebase: Add worker-loader #867

merged 10 commits into from Oct 6, 2021

Conversation

marcbouchenoire
Copy link
Contributor

Context: This PR is a fork of #815 from @TimDaub. I asked @developit if I could help unblock it by rebasing and fixing the last few remaining conflicts myself and this is it. After rebasing, I've also manually rewritten the commit history to ensure @TimDaub stays the author of all commits.

TimDaub and others added 9 commits July 20, 2021 16:58
Targets enhancement: #170
Enable usage of `microbundle --worker-loader` to apply rollup-plugin-web-worker-loader.

Allow bundling web workers automatically

- Add flag `--worker-loader`
- For format `es` and `modern`, a Worker `type: module` is automatically
bundled
Co-authored-by: Jason Miller <developit@users.noreply.github.com>
Co-authored-by: Jason Miller <developit@users.noreply.github.com>
Co-authored-by: Jason Miller <developit@users.noreply.github.com>
Co-authored-by: Jason Miller <developit@users.noreply.github.com>
Co-authored-by: Jason Miller <developit@users.noreply.github.com>
Co-authored-by: Jason Miller <developit@users.noreply.github.com>
@changeset-bot
Copy link

changeset-bot bot commented Jul 20, 2021

🦋 Changeset detected

Latest commit: 30242dd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
microbundle Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@TimDaub
Copy link
Contributor

TimDaub commented Jul 23, 2021

After rebasing, I've also manually rewritten the commit history to ensure @TimDaub stays the author of all commits.

Thanks for taking care of attribution <3

Copy link
Owner

@developit developit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! It would be nice to find an output mode that works with CJS, though I know that's something rollup-plugin-off-main-thread specifically throws an error for.

@developit developit merged commit 1b61029 into developit:master Oct 6, 2021
@preact-bot preact-bot mentioned this pull request Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants