Adds support for options.headers to be a Headers instance with an entries method (#124) #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is fixing the issue outlined in (#124). This allows consumers to use a Headers instance in their raw
fetch(url, options)call foroptions.headers, instead of being limited to only JavaScript object literals.The polyfill will now check if
options.headershas anentries()function. If it does, it will invoke that and expect to receive an iterable object, like the Headers.entries() API does, and then iterate over that.With this change, request headers as a Headers instance will be properly iterated and carried over correctly to the underlying XHR, instead of the current implementation which iterates on the method keys (
append(),delete(), etc)Unfortunately I could not add this support while keeping the original package under 500b, so I plan to limit these changes to my personal fork of unfetch.
EDIT: closing this PR, accidentally opened it against the main repo