Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always use file:// urls because of Windows #38

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mmomtchev
Copy link

Fixes #35

@Firegarden
Copy link

This does not address the fix in commonjs version

As far as I have tested line 201 of cjs\node.js needs to incorporate the same fix
eg import(URL.pathToFileURL(mod)).catch(err => {

@Firegarden
Copy link

I am confirming you can patch 2 lines of local package code to get this working as per Fixes 35

line 178 of node.js becomes
import(URL.pathToFileURL(mod))

also you need patch line 201 of cjs\node.js
import(URL.pathToFileURL(mod)).catch(err => {

this library is great to save you from learning node worker threads and thread pools

@Juliiiian
Copy link

i dont know if your still reading this but the fix is enough since on build the cjs/node.js will be created so its fine.

just sad to see that the prs are not getting merged

@mmomtchev
Copy link
Author

@Juliiiian alas, the fight for a European judicial system free of criminals is more important than this or that PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Importing ES6 modules does not work on Windows
3 participants