Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for webpack 4 #26

Merged
merged 1 commit into from
Feb 28, 2018
Merged

Fix for webpack 4 #26

merged 1 commit into from
Feb 28, 2018

Conversation

princemaple
Copy link
Contributor

@princemaple princemaple commented Feb 27, 2018 •
edited
Loading

@princemaple
Copy link
Contributor Author

Tested the change on my own project, seems to work!

@princemaple
Copy link
Contributor Author

Hi @developit is there anything more I need to do to get this PR merged?

@developit
Copy link
Owner

Nope, looks good to me!

@developit developit merged commit 41cff66 into developit:master Feb 28, 2018
@princemaple princemaple deleted the patch-1 branch February 28, 2018 02:22
@princemaple
Copy link
Contributor Author

Thanks for merging! 🎉 Could we have a new release published please?

@pkeuter
Copy link

pkeuter commented Mar 2, 2018

Hi @developit. Any reason this is not released yet?

@developit
Copy link
Owner

nope! releasing now

@developit
Copy link
Owner

Released as 1.0.2

@princemaple
Copy link
Contributor Author

princemaple commented Mar 3, 2018 via email

@pkeuter
Copy link

pkeuter commented Mar 15, 2018

Yeah thanks for this, ❤️ this loader!

@developit developit mentioned this pull request Apr 13, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@developit developit developit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not working on Webpack 4
3 participants
@princemaple @developit @pkeuter