Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #85: Use proper module name #90

Merged
merged 3 commits into from
May 18, 2020
Merged

Fix #85: Use proper module name #90

merged 3 commits into from
May 18, 2020

Conversation

shayke
Copy link

@shayke shayke commented May 17, 2020

Fixes #85

When ModuleConcatenationPlugin is on (which is the default in production) module.resource is not the same as the original one.

P.S
I couldn't find an easy way passing the tests the mode: production flag, or adding the ModuleConcatenationPlugin to a specific test, any pointers?

developit
developit approved these changes May 18, 2020
View reviewed changes
Copy link
Owner

@developit developit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a production test run in #91, and it was broken on master! I can confirm that it's fixed by this PR.

@developit developit merged commit d586b51 into developit:master May 18, 2020
@developit
Copy link
Owner

Published as 1.2.1 - thanks a ton!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@developit developit developit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Version 1.2.0 does not export function on worker instance in production mode
2 participants
@shayke @developit