Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: reverse the layer order for automatically split geometry #516

Merged
merged 7 commits into from
May 14, 2024
Merged

Feat: reverse the layer order for automatically split geometry #516

merged 7 commits into from
May 14, 2024

Conversation

RaczeQ
Copy link
Contributor

@RaczeQ RaczeQ commented May 13, 2024 •
edited

What I am changing

  • Layer order for objects with mixed geometry types

How I did it

Changed list appending order for split_mixed_gdf and parse_wkb_table function from [points, linestrings, polygons] to [polygons, linestrings, points]

How you can test it

  • Points and paths should be now plotted on top of polygon for better visibility.

Old:
Untitled

New:
image

Related Issues

#513

@RaczeQ RaczeQ mentioned this pull request May 13, 2024
Closed
kylebarron
kylebarron reviewed May 13, 2024
View reviewed changes
Copy link
Member

@kylebarron kylebarron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a couple nits

lonboard/_geoarrow/parse_wkb.py Outdated Show resolved Hide resolved
lonboard/_geoarrow/parse_wkb.py Outdated Show resolved Hide resolved
lonboard/_utils.py Outdated Show resolved Hide resolved
lonboard/_utils.py Outdated Show resolved Hide resolved
kylebarron
kylebarron approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@kylebarron kylebarron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kylebarron kylebarron enabled auto-merge (squash) May 14, 2024 15:01
@kylebarron kylebarron merged commit 68cc745 into developmentseed:main May 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylebarron kylebarron kylebarron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RaczeQ @kylebarron