-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invert layers order in split_mixed_gdf
function
#513
Comments
I've created a #516 PR for this issue 😉 |
kylebarron
added a commit
that referenced
this issue
May 14, 2024
## What I am changing <!-- What were the high-level goals of the change? --> - Layer order for objects with mixed geometry types ## How I did it Changed list appending order for `split_mixed_gdf` and `parse_wkb_table` function from [`points`, `linestrings`, `polygons`] to [`polygons`, `linestrings`, `points`] ## How you can test it <!-- How might a reviewer test your changes to verify that they work as expected? --> - Points and paths should be now plotted on top of polygon for better visibility. Old: ![Untitled](https://github.com/developmentseed/lonboard/assets/17250607/f0d4a4f5-d69d-4e27-bbc7-3d159d1d2e6b) New: ![image](https://github.com/developmentseed/lonboard/assets/17250607/8e154ff7-996a-4556-9406-daa355d4184a) ## Related Issues #513 --------- Co-authored-by: Kyle Barron <kyle@developmentseed.org>
Closed by #516 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What do you think about changing the order of gdfs and subsequently layers to keep points and lines on top of polygons? It seems natural to me, but I don't know if it's viable to do so.
lonboard/lonboard/_utils.py
Lines 143 to 161 in b2ca192
The text was updated successfully, but these errors were encountered: