Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define a way to contribute environment variables to all the workspace POD containers #149

Closed
davidfestal opened this issue Oct 5, 2020 · 3 comments
Labels
area/api Enhancement or issue related to the api/devfile specification
Milestone

Comments

@davidfestal
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

This feature was part of the devfile 1.0 plugin definitions (meta.yaml), and it would obviously be necessary in a number of use-cases.

Describe the solution you'd like

We would need a way in the Devfile 2.0 to declaratively add environment variables that would be added globally in the workspace, which means in all containers of the workspace POD.

Describe alternatives you've considered

Not aware about other ways to do the same thing.

@elsony elsony added this to the 2.0 milestone Oct 5, 2020
@elsony elsony added the area/api Enhancement or issue related to the api/devfile specification label Oct 8, 2020
@elsony elsony modified the milestones: 2.0, 2.1, 2.2 Oct 29, 2020
@kadel
Copy link
Member

kadel commented Nov 10, 2020

How common is this use case?
If only 2% of users will ever do this Shouldn't be enough to just say that this is done by adding variables to all containers?

@elsony
Copy link
Contributor

elsony commented Nov 26, 2020

This requirement will be addressed by a more generic solution to provide a top-level attribute mechanism #239. Therefore, I am closing this off and this item is no longer a priority for 2.1.

@elsony elsony closed this as completed Nov 30, 2020
@amisevsk
Copy link
Contributor

amisevsk commented Mar 1, 2021

This requirement will be addressed by a more generic solution to provide a top-level attribute mechanism #239. Therefore, I am closing this off and this item is no longer a priority for 2.1.

Worth noting that these are subtly different use cases -- global attributes are useful for defining string replacements within the devfile, but they cannot add environment variables where none exist. Global attributes wouldn't support the functionality David is describing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Enhancement or issue related to the api/devfile specification
Projects
None yet
Development

No branches or pull requests

4 participants