Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump up github.com/docker/docker to v25.0.6 version. #1620

Closed
12 tasks done
thepetk opened this issue Aug 6, 2024 · 4 comments
Closed
12 tasks done

Bump up github.com/docker/docker to v25.0.6 version. #1620

thepetk opened this issue Aug 6, 2024 · 4 comments
Assignees
Labels
area/library Common devfile library for interacting with devfiles area/registry Devfile registry for stacks and infrastructure area/test-automation Test automation for devfile specification and library severity/blocker Issues that prevent developers from working

Comments

@thepetk
Copy link
Contributor

thepetk commented Aug 6, 2024

Which area is this issue related to?

/area library
/area registry
/area test-automation

Issue Description

The following repos need to be updated and their modules should use github.com/docker/docker version v25.0.6

devfile/library

devfile/registry

devfile/registry-support

devfile/registry-operator

Acceptance Criteria

  • All modules in library, registry, registry-support & registry-operator are using github.com/docker/docker v25.0.6
@openshift-ci openshift-ci bot added area/library Common devfile library for interacting with devfiles area/registry Devfile registry for stacks and infrastructure area/test-automation Test automation for devfile specification and library labels Aug 6, 2024
@Jdubrick Jdubrick self-assigned this Aug 13, 2024
@Jdubrick
Copy link
Contributor

Since the dependency bump is a critical severity we should be cutting new releases for affected items, I can cut a new library release so we can pull that dependency into most of the action items

@Jdubrick
Copy link
Contributor

Added action item to registry-operator to bump up the registry-library hash to pull in the fix as well: https://github.com/devfile/registry-operator/blob/main/go.mod#L7

@thepetk
Copy link
Contributor Author

thepetk commented Aug 14, 2024

Since the dependency bump is a critical severity we should be cutting new releases for affected items, I can cut a new library release so we can pull that dependency into most of the action items

+1 for the new release. Initially I thought only updating the hash but it feels much cleaner. I've updated the criteria to include this action. As you're now the assignee feel free to update them as you see fit <3

@thepetk thepetk added the severity/blocker Issues that prevent developers from working label Aug 14, 2024
@thepetk
Copy link
Contributor Author

thepetk commented Aug 14, 2024

blocks #1605

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/library Common devfile library for interacting with devfiles area/registry Devfile registry for stacks and infrastructure area/test-automation Test automation for devfile specification and library severity/blocker Issues that prevent developers from working
Projects
Status: Done ✅
Development

No branches or pull requests

2 participants