Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate devfile/api validator in devfile/library #337

Closed
yangcao77 opened this issue Feb 2, 2021 · 1 comment
Closed

Integrate devfile/api validator in devfile/library #337

yangcao77 opened this issue Feb 2, 2021 · 1 comment
Assignees
@yangcao77
Labels
area/library Common devfile library for interacting with devfiles

Comments

@yangcao77
Copy link
Contributor

As redhat-developer/odo#4085 has been merged in api repo, the validator is ready to be integrated within devfile/library.

The validation functions should be called after the devfile has been parsed and flattened, and returns error if the devfile is invalid.
@yangcao77 yangcao77 self-assigned this Feb 2, 2021
@yangcao77 yangcao77 added the area/library Common devfile library for interacting with devfiles label Feb 2, 2021
@elsony elsony changed the title Integrate devfile/api validator in devfile/libaray Integrate devfile/api validator in devfile/library Feb 2, 2021
@yangcao77 yangcao77 mentioned this issue Feb 4, 2021
Merged
@yangcao77
Copy link
Contributor Author

This issue still has project & starterproject validation left.

It is due to the bug in devfile/api: #339
Move this issue back to in progress since it is currently blocked by #339, will need another PR to adopt new change in devfile/api after 339 has been merged

@yangcao77 yangcao77 mentioned this issue Feb 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yangcao77 yangcao77

Labels
area/library Common devfile library for interacting with devfiles
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yangcao77