-
Notifications
You must be signed in to change notification settings - Fork 96
Reverted python id #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reverted python id #125
Conversation
Signed-off-by: Paul Schultz <pschultz@pobox.com>
|
@schultzp2020: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
You may also want to test out on the ODC case to make sure the changes fixes the problem on ODC sample scenario as well. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: maysunfaisal, schultzp2020 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/hold until ODC test confirmed |
|
Cannot test on ODC because this is a stack. |
| metadata: | ||
| name: python-flask | ||
| name: python | ||
| version: 2.0.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the version be incremented in big changes like this?
Signed-off-by: Paul Schultz pschultz@pobox.com
What does this PR do?:
Reverts python id
Which issue(s) this PR fixes:
#123 changed the python id and broke parent support.
Have you read the devfile registry contributing guide and followed its instructions?
Does this repository's tests pass with your changes?
Does any documentation need to be updated with your changes?
Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)
How to test changes / Special notes to the reviewer: