Skip to content

Conversation

@schultzp2020
Copy link
Contributor

@schultzp2020 schultzp2020 commented Sep 22, 2022

Signed-off-by: Paul Schultz pschultz@pobox.com

What does this PR do?:

Reverts python id

Which issue(s) this PR fixes:

#123 changed the python id and broke parent support.

  • Contributing guide
    Have you read the devfile registry contributing guide and followed its instructions?
  • Test automation
    Does this repository's tests pass with your changes?
  • Documentation
    Does any documentation need to be updated with your changes?
  • Check Tools Provider
    Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)

How to test changes / Special notes to the reviewer:

Signed-off-by: Paul Schultz <pschultz@pobox.com>
@schultzp2020 schultzp2020 self-assigned this Sep 22, 2022
@openshift-ci
Copy link

openshift-ci bot commented Sep 22, 2022

@schultzp2020: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.11-images c64da0f link true /test v4.11-images
ci/prow/v4.11-registry-test c64da0f link true /test v4.11-registry-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@elsony
Copy link
Contributor

elsony commented Sep 22, 2022

You may also want to test out on the ODC case to make sure the changes fixes the problem on ODC sample scenario as well.

@openshift-ci openshift-ci bot added the lgtm Looks good to me label Sep 22, 2022
@openshift-ci
Copy link

openshift-ci bot commented Sep 22, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: maysunfaisal, schultzp2020
Once this PR has been reviewed and has the lgtm label, please assign johnmcollier for approval by writing /assign @johnmcollier in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@maysunfaisal
Copy link
Member

/hold

until ODC test confirmed

@johnmcollier johnmcollier merged commit 6b84ba7 into devfile:main Sep 22, 2022
@schultzp2020 schultzp2020 deleted the change-python-id branch September 22, 2022 20:42
@maysunfaisal
Copy link
Member

Cannot test on ODC because this is a stack.
If one needs to test on ODC, then you need to update sample

metadata:
name: python-flask
name: python
version: 2.0.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the version be incremented in big changes like this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Looks good to me

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants