Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If I've already filled in for this time period, why am I getting another reminder? #40

Closed
annashipman opened this issue Apr 29, 2013 · 5 comments
Assignees

Comments

@annashipman
Copy link
Member

Hmmm.

Related to #38 and #39, I don't think we've got this quite right.

I have already filled in for the last week, w/c 22nd April. So I would expect my next email, "Let us know how you did" to be at the end of that time period, i.e. on the 5th of May, so I can tell you how I did in the preceding week.

However, I got one this morning, and following the link, it's asking me about the week commencing today.

I will take a look at all three of these issue when I get a moment.

@dvberkel
Copy link

I have the same problem.

I am receiving "Let us know how you did" emails for the current week. They even occur before any of the scheduled habits.

I would expect these emails to come after the a habit was scheduled to occur.

@annashipman
Copy link
Member Author

Hi Daan,

I've actually already fixed this bug (see associated merge) but I haven't yet deployed it because I've not been able to test the migration. I didn't have time before my holiday (which I am now on 😄 ) so it will take us a few weeks to get this deployed - sorry about that, and thanks very much for your report!

@dvberkel
Copy link

Hi Anna,

Enjoy your holiday! It is well deserved.

I am in no hurry to see this deployed. Take your time to make behabitual even better. Looking forward to it.

@annashipman
Copy link
Member Author

It's taken a bit more than "a few weeks" but I have now deployed this change 😄

Thanks again for your input.

@dvberkel
Copy link

Great to see this improvement. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants