This repository has been archived by the owner on Feb 22, 2024. It is now read-only.
setting status through select ignores whitespace #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Chrome, tests failed because the setting a status included a comparison to the status getText(), which included white space. New test implementation ignores the whitespace, and now should work in both firefox and chrome.
|
Good catch! Will merge tomorrow :) |
Another select element whose options are compared, for which the white space from the getElement needs to be stripped.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Chrome, tests failed because the setting a status included a comparison to the status getText(), which
included white space.
New test implementation ignores the whitespace, and now should work in both firefox and chrome.