This repository has been archived by the owner on Feb 22, 2024. It is now read-only.
Using chrome instead of firefox for webdriver. #413
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
And we should update the |
|
The two tests failing for chrome have been fixed in #414, and now work for FF and Chrome. |
|
Getting travis to use chrome maybe a bit more involved than I thought. And the tests work well with Firefox 46, so I propose to close this PR for now. |
|
Seems a bit complicated indeed. Linking to the related issue on the Travis tracker: travis-ci/travis-ci#272 (comment) . Lets not remove the branch for future reference, maybe some developers want to use it in their personal configuration. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firefox 47 does not play well with webdriver 2.53:
http://stackoverflow.com/questions/37693106/selenium-2-53-not-working-on-firefox-47
Switched to chrome instead of downgrading my firefox to 46. (you may have to (brew) install
chromedriver)For me two tests fail at the moment, both related to setting the state in the DeliveryReviewView.