Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad parsing of protocol in "Devices With Path" command on windows #222

Open
yannayl opened this issue Jan 3, 2022 · 1 comment
Open

Comments

@yannayl
Copy link

yannayl commented Jan 3, 2022

When running the DevicesWithPath command against ADB server on windows, the following line is returned:
AAAAAAAA device product:OnePlus7 model:GM1903 device:OnePlus7 transport_id:1
The parsing of this line wrongly parses the encoded fields and returns the following object:

{
  device:'transport_id:1',
  id:'AAAAAAAA',
  model:'device:OnePlus7',
  path:'product:OnePlus7',
  product:'model:GM1903',
  transportId:undefined,
  type:'device',
}

Which is incorrect.

SDK Version: r30.0.5-windows
adbkit Version: "3.2.1"

@NoahAndrews
Copy link

NoahAndrews commented Jan 21, 2022

#13 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants