Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: pypi (original, original-wordmark, plain, plain-wordmark) #1697

Merged
merged 11 commits into from
Apr 28, 2023

Conversation

yeyeto2788
Copy link
Contributor

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #922

Link to prove your SVG is correct and up-to-date.

@yeyeto2788
Copy link
Contributor Author

Sorry for the delay on this one guys! My bad. If there is anything I need to change or add let me know.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2023

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60



SVG Error in 'pypi-original.svg':
- 'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg.

SVG Error in 'pypi-original-wordmark.svg':
- 'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg.

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2023

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60



SVG Error in 'pypi-original.svg':
- 'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg.
- SVG contains `stroke` property. This will get ignored by Icomoon. Please convert them to fills.

SVG Error in 'pypi-original-wordmark.svg':
- 'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg.
- SVG contains `stroke` property. This will get ignored by Icomoon. Please convert them to fills.

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a few things that need to be changed, so I'll give a brief overview here.
Read each comment for more info.

Some things that need to be fixed:

  1. Move devicon.json object to correct line, so that the file is alphabetically sorted
  2. Add altnames in devicon.json
  3. Change to correct color in devicon.json
  4. Remove TM from original-wordmark
  5. Resize both icons to viewbox="0 0 128 128"

Optional (recommended):

  1. Add plain and plain-wordmark versions
  2. Add line and line-wordmark versions

devicon.json Outdated Show resolved Hide resolved
icons/pypi/pypi-original-wordmark.svg Outdated Show resolved Hide resolved
icons/pypi/pypi-original.svg Outdated Show resolved Hide resolved
devicon.json Outdated Show resolved Hide resolved
devicon.json Outdated Show resolved Hide resolved
devicon.json Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2023

Hi!

I'm the check-bot and we have some issues with your PR:



Error found regarding filenames:
- This path doesn't exist: '/home/runner/work/devicon/devicon/icons/pypi/pypi-plain.svg'

Error checking SVGs: no SVGs to check. Might be caused by above issues.

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2023

Hi!

I'm the check-bot and we have some issues with your PR:



Error found regarding filenames:
- This path doesn't exist: '/home/runner/work/devicon/devicon/icons/pypi/pypi-plain.svg'

Error checking SVGs: no SVGs to check. Might be caused by above issues.

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2023

Hi!

I'm the check-bot and we have some issues with your PR:



Error found regarding filenames:
- This path doesn't exist: '/home/runner/work/devicon/devicon/icons/pypi/pypi-plain.svg'

Error checking SVGs: no SVGs to check. Might be caused by above issues.

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@Panquesito7 Panquesito7 added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Mar 7, 2023
@lunatic-fox lunatic-fox changed the title new icon: Pypi (original,original-wordmark) new icon: Pypi (original, original-wordmark, plain, plain-wordmark) Mar 23, 2023
@lunatic-fox lunatic-fox added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Mar 23, 2023
@lunatic-fox lunatic-fox added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Mar 23, 2023
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

devicon.json Outdated Show resolved Hide resolved
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work fixing all of the issues in one go 💯
Thank you for the contribution! ✔️

@Panquesito7 Panquesito7 changed the title new icon: Pypi (original, original-wordmark, plain, plain-wordmark) new icon: pypi (original, original-wordmark, plain, plain-wordmark) Apr 21, 2023
@Panquesito7 Panquesito7 merged commit 2fbbb98 into devicons:develop Apr 28, 2023
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants