deps: support numpy 2.0 #2391
Merged
deps: support numpy 2.0 #2391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mloubout
added
dependencies
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2391 +/- ##
=======================================
Coverage 86.77% 86.78%
=======================================
Files 234 234
Lines 44265 44271 +6
Branches 8183 8184 +1
=======================================
+ Hits 38410 38419 +9
+ Misses 5140 5137 -3
Partials 715 715 ☔ View full report in Codecov by Sentry. |
mloubout
force-pushed
the
numpy2
branch
2 times, most recently
from
bb3cbc8
to
f7c7d5c
Compare
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
conftest.py
Outdated
| @@ -453,3 +455,10 @@ def check_array(array, exp_halo, exp_shape, rotate=False): | |||
|
|
|||
| assert tuple(array.halo) == exp_halo | |||
| assert tuple(shape) == tuple(exp_shape) | |||
|
|
|||
|
|
|||
| # Make Ipython use str for numpy dtypes | |||
There was a problem hiding this comment.
wow, is that necessary for numpy 2?
|
|
||
| # Due to api changes in numpy 2.0, it requires sympy 1.12.1 at the minimum | ||
| # Check if sympy is installed and enforce numpy version accordingly. | ||
| # If sympy isn't installed, endforce sympy>=1.12.1 and numpy>=2.0 |
FabioLuporini
approved these changes
Jun 24, 2024
EdCaunt
approved these changes
Jun 25, 2024
mloubout
force-pushed
the
numpy2
branch
2 times, most recently
from
b906ee0
to
5df90ea
Compare
FabioLuporini
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.