Amend prototypes for exception handlers and interrupt handlers/callbacks #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_exceptionhandlertable expected functions that take a frame_context*.
IRQ_Request expects a function taking a u32 followed by a void* context pointer. The only reason this didn't cause warnings previously is because an old-style prototype was used.
mtheall
reviewed
Apr 17, 2018
libogc/system.c
Outdated
| @@ -437,7 +437,7 @@ static void __STMEventHandler(u32 event) | |||
| if(ret) { | |||
| _CPU_ISR_Disable(level); | |||
| __sys_resetdown = 1; | |||
| __RSWCallback(); | |||
| __RSWCallback(IRQ_PI_RSW, NULL); | |||
There was a problem hiding this comment.
Should this also have the "if(__RSWCallback)" check?
There was a problem hiding this comment.
Indeed. Good catch, I'll update that.
…callback in __STMEventHandler() __RSWHandler() checks if the callback is valid before calling it, so we should do the same here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__exception_sethandler()expects handler functions taking aframe_context*, andIRQ_Requestexpects functions taking au32signifying an IRQ and avoid*for passing along any extra contextual data.