Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sass version is behind #16

Closed
bensampaio opened this issue Jun 24, 2016 · 4 comments
Closed

Sass version is behind #16

bensampaio opened this issue Jun 24, 2016 · 4 comments
Labels

Comments

@bensampaio
Copy link

bensampaio commented Jun 24, 2016

I have the following HTML:

<div class="grid">
  <div class="col-12">
    <div class="box"></div>
  </div>
  <div class="col-3_sm-12">
    <div class="box"></div>
  </div>
  <div class="col-9_sm-12">
    <div class="box"></div>
  </div>
  <div class="col-3_sm-12">
    <div class="box"></div>
  </div>
  <div class="col-9_sm-12">
    <div class="box"></div>
  </div>
  <div class="col-3_sm-12">
    <div class="box"></div>
  </div>
  <div class="col-9_sm-12">
    <div class="box"></div>
  </div>
  <div class="col-6_xs-12 grid">
    <div class="col-6_sm-12">
      <div class="box"></div>
    </div>
    <div class="col-6_sm-12">
      <div class="box"></div>
    </div>
  </div>
  <div class="col-6_xs-12 grid">
    <div class="col-6_sm-12">
      <div class="box"></div>
    </div>
    <div class="col-6_sm-12">
      <div class="box"></div>
    </div>
  </div>
  <div class="col-6_xs-12 grid">
    <div class="col-6_sm-12">
      <div class="box"></div>
    </div>
    <div class="col-6_sm-12">
      <div class="box"></div>
    </div>
  </div>
  <div class="col-6_xs-12 grid">
    <div class="col-6_sm-12">
      <div class="box"></div>
    </div>
    <div class="col-6_sm-12">
      <div class="box"></div>
    </div>
  </div>
  <div class="col-3_sm-12">
    <div class="box"></div>
  </div>
  <div class="col-9_sm-12">
    <div class="box"></div>
  </div>
  <div class="col-12">
    <div class="box"></div>
  </div>
</div>

When I load your css via cdnjs I get the result I want:

with cdn

When I include your SASS files into my SASS files I get the following result:

screen shot 2016-06-24 at 11 32 42

Working example: https://jsfiddle.net/dg4k84zj/.

Would it be possible to fix that? I would prefer to import the sass files instead of using the generated CSS, since I want to be able to access your SASS variables... Thank you!

@devlint
Copy link
Owner

devlint commented Jul 13, 2016

Hi!
Indeed there was a little mistake in sass version. Sorry.
Version 2.1.1 is up-to-date.
Can you try and close the issue?
Thx you

@bensampaio
Copy link
Author

bensampaio commented Jul 13, 2016

It looks better but there is still a little problem with columns that also work as grids. Example html:

<div id="container" class="grid">
  <div id="parent1" class="col-6 grid">
    <div class="col-3"></div>
    <div class="col-9"></div>
  </div>
  <div id="parent2" class="col-6 grid">
    <div class="col-6"></div>
    <div class="col-6"></div>
  </div>
</div>

With the example above:

  • If I use the already generated CSS #parent1 and #parent2 have no padding but the inner columns do (which is what I would expect);
  • If I use the SASS version, then #parent1, #parent2 and their child columns have padding.

@devlint
Copy link
Owner

devlint commented Aug 25, 2016

Hello, for me v2.2.0 compilation from Sass source works well.
Here your fiddle with gridlex.css compiled from sass included:
https://jsfiddle.net/devlint/zro50zmx/1/
Can you try again? Thx

@bensampaio
Copy link
Author

The issue is fixed indeed. I just realised the problem I mentioned on my last reply was being caused by CSS Modules. So basically, if someone comes across this same problem, you shouldn't import CSS meant to be global inside of a CSS Module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants