Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Untabification of readme.txt #3

Merged
merged 1 commit into from
May 29, 2016
Merged

Conversation

atifaziz
Copy link
Contributor

Helps avoid warnings of mixed tabs and spaces in VS editor like:

image

This happens when someone copies the following text from readme.txt into their AssemblyInfo.cs:

[assembly: AssemblyVersion (ThisAssembly.Git.SemVer.Major + "." + ThisAssembly.Git.SemVer.Minor + "." + ThisAssembly.Git.SemVer.Patch)]
[assembly: AssemblyInformationalVersion (
    ThisAssembly.Git.SemVer.Major + "." +
    ThisAssembly.Git.SemVer.Minor + "." +
    ThisAssembly.Git.SemVer.Patch + "-" +
    ThisAssembly.Git.Branch + "+" +
    ThisAssembly.Git.Commit)]

Helps avoid warnings of mixed tabs and spaces in editors
@kzu
Copy link
Member

kzu commented Mar 14, 2016

Being tabs the default in VS for C#, I think we just need to pick one and live with the fact that some will see that warning.

Thoughts?

@atifaziz
Copy link
Contributor Author

I felt that tabs may have crept in accidentally so thought I'd help out with a PR. However, if they are intentional then I can live with the warning and fix on my end each time. It's not a lot of work at all so no need to go down a tab vs. spaces rabbit-hole (that always runs deep). I'll leave the decision to you. You can merge or you can just close with the peace of mind that I will be neither offended not disheartened. 😄

@kzu
Copy link
Member

kzu commented Mar 14, 2016

Fair enough. I'll leave it open so that more users wanting the change (or not ;)) can chime in though.

Thanks!

@kzu kzu merged commit 10e1fe0 into devlooped:master May 29, 2016
@kzu
Copy link
Member

kzu commented May 29, 2016

I think for the readme it's fine to unify on spaces

@devlooped devlooped locked and limited conversation to collaborators Sep 11, 2024
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants