Sample analyzer and packaging cleanup #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes hidden diagnostics to denote design-time build and non-editor builds. These may not be needed now that we don't do I/O at all.
Also to retrieve the latest expiration found in claims.
We were not reporting progress while fetching manifest from pre-authenticated user account.
We can rely soley on System.Identity.Tokens for reading the security key. This simplifies dependencies and package size for analyzers that do just validation.
We don't need any of that anymore. The standard format makes it trivial for anyone to just read it, validate it and perform a check, regardless of programming language.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.