Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downgrade System.ValueTuple & System.Threading.Tasks.Extensions #571

Merged
merged 3 commits into from
Jan 8, 2018
Merged

Downgrade System.ValueTuple & System.Threading.Tasks.Extensions #571

merged 3 commits into from
Jan 8, 2018

Conversation

stakx
Copy link
Contributor

@stakx stakx commented Jan 8, 2018

Hopefully, this will take care of the better part of #566 and #567 and restore better compatibility of Moq with the full .NET Framework <4.7.1.

@stakx
Add missing package reference for System.ValueTuple to .nuspec
e69311e
@stakx
Downgrade System.Threading.Tasks.Extensions to 4.3.0
a458fcf 
This might fix devlooped#566. If not, then at least there's a good chance it
will make that issue less likely to surface.
@stakx
Downgrade System.ValueTuple to 4.3.0
0c40d58 
This is probably overly careful. But given that Moq targets `net45`,
let's pick a version of `System.ValueTuple` that targets that frame-
work version precisely. (Version 4.4.0 only targets `net461` and up-
wards, and also targets .NET Core 2.0 which we probably want to
avoid for now.)
@stakx stakx merged commit 8eb0892 into devlooped:master Jan 8, 2018
@stakx stakx deleted the nuget-package-refs branch January 8, 2018 20:48
@abatishchev
Copy link
Contributor

Is it possible to do not reference other/Core packages on Full .NET?

@stakx
Copy link
Contributor Author

stakx commented Jan 12, 2018 •
edited

Yes, but then Moq loses ValueTask<> and ValueTuple<> support. (These packages do contain an assembly targeting the full .NET framework, it's just that the build tools apparently prefer the .NET Standard assemblies instead.)

@abatishchev
Copy link
Contributor

For me it would be fine. I'd like to see this support via an additional package, i.e. Moq.ValueTuple, or via a major version bump, I believe adding new major dependencies is a good reason for that. Personally hate to install additional packages which I don't need.

@stakx
Copy link
Contributor Author

stakx commented Jan 12, 2018

See the discusssion in #566 about a separate package. While possible, the split would be a little awkward. I'd rather just remove ValueX<> support completely until .NET tooling is reasonably reliable again.

@abatishchev
Copy link
Contributor

Thanks, will read it. Meanwhile I'm all for the removal of such until a better time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stakx @abatishchev