Remove catch & (re-) throw in Raise
#771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two reasons for this:
1. It is one of the very few, if not the only, place where we do this
"to keep Moq noise out" of the stack trace.
2. An earlier refactor in `InvokePreserveStack` that switched to
using `ExceptionDispatchInfo` already leads to cleaner stack
traces than what we had previously. It's likely the "Moq noise"
is at a tolerable level now. (If it weren't, we'd have to intro-
duce the same re-throwing pattern in all other public APIs.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two reasons for this:
It is one of the very few, if not the only, place where we do this "to keep Moq noise out" of the stack trace.
An earlier refactor in
InvokePreserveStackthat switched to usingExceptionDispatchInfoalready leads to cleaner stack traces than what we had previously. It's likely the "Moq noise" is at a tolerable level now. (If it weren't, we'd have to introduce the same re-throwing pattern in all other public APIs.Resolves #738.