Allow raising events on inner mocks #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stakx
commented
Mar 7, 2019
|
|
||
| var expression = ExpressionReconstructor.Instance.ReconstructExpression(eventExpression); | ||
|
|
||
| // TODO: validate that expression is for event subscription or unsubscription |
There was a problem hiding this comment.
An obvious TODO left to do.
|
|
||
| var expression = ExpressionReconstructor.Instance.ReconstructExpression(eventExpression); | ||
|
|
||
| // TODO: validate that expression is for event subscription or unsubscription |
There was a problem hiding this comment.
As above, to this TODO.
That is, convert these API methods to use `ExpressionReconstructor` to turn the += expressions into `LambdaExpression`s, then use the new re- cursive approach based on setup expression splitting.
stakx
force-pushed
the
raise-inner-mock-events
branch
from
ea4fa5f
to
2cc4d64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #166, i.e. when
mock.Raiseis given an event+= nullexpression for a sub-mock's event, then Moq will now raise the event on that sub-mock instead of on the root mock. This is achieved by the new machinery we recently added in #767 (improved expression reconstruction from delegates) and #765 (expression splitting & recursive processing).