Turn AmbientObserver into MatcherObserver
#775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`AmbientObserver` is no longer used to track mock invocations, as all expression reconstruction from delegates now happens on separate recording proxies. Give it a new, more accurate name. Also, remove `MatcherObserver` from the mock invocation pipeline, it no longer has any effect there.
stakx
force-pushed
the
refactor-ambientobserver
branch
from
4ca634f
to
30f5b99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactoring & dead code eliminiation.
AmbientObserveris no longer used to track mock invocations, as all expression reconstruction from delegates now happens on separate recording proxies (thanks to #774 and #767). Give it a new, more accurate name.Also, remove
AmbientObserverfrom the mock invocation pipeline, it no longer has any effect there.