Don't request DTE via COM since it can hang VS #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were forcedly attempting to retrieve the DTE from the just-started devenv process, and this was another cause of hangs. Since the .NET injection itself doesn't depend on anything VS-specific, just do a quick warmup wait instead before just injecting the process, since the first test run will already do the VS-friendly wait for devenv to fully initialize. Also, successful injection should only be a zero exit code.
No need to request zombie property, already have the ShellInitialized before.
This should preserve the init wait we had, without blocking on COM object retrieval.
This should increase the chances we can successfully connect to it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were forcedly attempting to retrieve the DTE from the just-started devenv process, and this was another cause of hangs. Since the .NET injection itself doesn't depend on anything VS-specific, just do a quick warmup wait instead before just injecting the process, since the first test run will already do the VS-friendly wait for devenv to fully initialize.