Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't request DTE via COM since it can hang VS #50

Merged
merged 11 commits into from
Aug 30, 2022
Merged

Don't request DTE via COM since it can hang VS #50

merged 11 commits into from
Aug 30, 2022

Commits on Aug 29, 2022

  1. Don't request DTE via COM since it can hang VS 

    We were forcedly attempting to retrieve the DTE from the just-started devenv process, and this was another cause of hangs. Since the .NET injection itself doesn't depend on anything VS-specific, just do a quick warmup wait instead before just injecting the process, since the first test run will already do the VS-friendly wait for devenv to fully initialize.

Also, successful injection should only be a zero exit code.
    @kzu
    kzu committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    178830e View commit details
    Browse the repository at this point in the history

  2. Simplify first run init 

    No need to request zombie property, already have the ShellInitialized before.
    @kzu
    kzu committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    861b85e View commit details
    Browse the repository at this point in the history

  3. Wait for DTE but don't retrieve it 

    This should preserve the init wait we had, without blocking on COM object retrieval.
    @kzu
    kzu committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    df40ac0 View commit details
    Browse the repository at this point in the history

  4. Remove hardcoded sync context and initial message bus call

    @kzu
    kzu committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    1df69b1 View commit details
    Browse the repository at this point in the history

  5. Upload other logs too

    @kzu
    kzu committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    ee20713 View commit details
    Browse the repository at this point in the history

  6. Don't turn on diagnostic messages by default

    @kzu
    kzu committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    c1630dd View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2022

  1. Apply format

    @kzu
    kzu committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    9fc7ad3 View commit details
    Browse the repository at this point in the history

  2. Add an explicit initialize step to wait for VS

    @kzu
    kzu committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    4589c4c View commit details
    Browse the repository at this point in the history

  3. Increase default number of retries and interval for VS startup 

    This should increase the chances we can successfully connect to it.
    @kzu
    kzu committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    75419c8 View commit details
    Browse the repository at this point in the history

  4. Reset and start both regular and experimental VS once

    @kzu
    kzu committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    427e1bd View commit details
    Browse the repository at this point in the history

  5. Apply dotnet format

    @kzu
    kzu committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    b98086e View commit details
    Browse the repository at this point in the history