Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve module integration #20

Closed
jguix opened this issue Oct 27, 2017 · 4 comments
Closed

Improve module integration #20

jguix opened this issue Oct 27, 2017 · 4 comments

Comments

@jguix
Copy link

jguix commented Oct 27, 2017

The scripts and CSS references in the index.html shouldn't be necessary.

I am working on a big angular project in which this kind of integration, by putting script and link tags in the index.html is not acceptable.

@jguix
Copy link
Author

jguix commented Oct 27, 2017

@devmark Please let me know if I can help you moving this issue. Otherwise I will need to search for another similar component.

@Taewa
Copy link

Taewa commented Nov 28, 2017

Hi @jguix
Which index.html you are talking about?

By the way, did you find another similar component?

@jguix
Copy link
Author

jguix commented Nov 28, 2017

I was talking about the Installation section of the README, where it states that you should include jquery and ng-slick in the application as so:

Include jquery and slick css/js in your application :

<script src="//code.jquery.com/jquery-3.2.1.min.js"></script>
<link rel="stylesheet" type="text/css" href="//cdn.jsdelivr.net/jquery.slick/1.6.0/slick.css"/>
<link rel="stylesheet" type="text/css" href="//cdn.jsdelivr.net/jquery.slick/1.6.0/slick-theme.css"/>
<script src="https://unpkg.com/slick-carousel@1.6.0/slick/slick.js"></script>

Even though I succeeded to include the library configuring the angular.cli.json instead of modifying the index.html, we finally opted for a different solution.

Alternatives are:
https://github.com/zefoy/ngx-swiper-wrapper
https://github.com/sheikalthaf/ngx-carousel

@Taewa
Copy link

Taewa commented Nov 28, 2017

@jguix
Ok I see. Mine as well, I had to add them to angular.cli.json.

I am experiencing a performance issue because I have 30 ngx-slick in the same page.
I guess that this.carousel.addSlide(this); occurs a lot of re-painting process but not 100% sure. Or I have just too many items.

Thanks for your alternatives!

@devmark devmark closed this as completed Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants