Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DockerUrlUpdater not finding/adding specific versions #44

Open
moritzLanger opened this issue Sep 25, 2023 · 2 comments
Open

DockerUrlUpdater not finding/adding specific versions #44

moritzLanger opened this issue Sep 25, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@moritzLanger
Copy link
Contributor

moritzLanger commented Sep 25, 2023

Expected behavior

The DockerUrlUpdater should be able to find the versions of DockerDesktop with their download links. Ideally we can identify the stable download link for the latest version and determine (stable) SHA-256 checksums for the downloads so we do not need the manual latest version entry hacke (see also devonfw/ide#1293)

Actual behavior

No versions of DockerDesktop are found at all. It seems that the HTML structure has changed and the entire approach to crawl HTML websites with regex patterns will never be stable. However, DockerDesktop does not offer a well designed "API" for their downloads that we can use.

Steps to reproduce (bug) / Use Case of feature request (enhancement)

  1. Watch the logs and the result of the github action update-urls or run the URL-Updater Process locally on your machine.

Related/Dependent Issues

Comments/Hints:

Suspected is that the Bug stemms from the else case in line 561 of the AbstractUrlUpdater is combined with the wrong if and should be moved one layer outside.

Affected version:

  • ide-URLs
@moritzLanger moritzLanger added the bug Something isn't working label Sep 25, 2023
@jan-vcapgemini
Copy link
Contributor

The issue seems to be caused by the DockerUrlUpdater.
Something must have been changed on their releases website again so that the regex we check does not match anymore.

@hohwille
Copy link
Member

hohwille commented Sep 26, 2023

@hohwille hohwille changed the title UrlUpdater skipping entire tool if one status is manual DockerUrlUpdater not finding/adding specific versions Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants