Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose configuration options to pass to istanbul #10

Closed
plumlee opened this issue Jan 8, 2015 · 3 comments
Closed

Expose configuration options to pass to istanbul #10

plumlee opened this issue Jan 8, 2015 · 3 comments

Comments

@plumlee
Copy link

plumlee commented Jan 8, 2015

First, thanks for a great tool. It's solved an issue that I've spent days on - how to get code coverage of the source files versus the browserified ones.

I'm using http://theintern.io as the testing framework for our application. It uses a custom coverageVariable of __internCoverage, and also uses the noCompact: true option. I'd like to be able to pass those directly to browserify-istanbul as configuration params, but the current format doesn't allow it.

Would you be open to a change/pull request that creates the instrumenter inside the transform function, so that options such as the coverageVariable could then be passed through to the istanbul.Instrumenter instantiation call?

@plumlee
Copy link
Author

plumlee commented Jan 20, 2015

Bump.

@plumlee
Copy link
Author

plumlee commented Jan 29, 2015

Not much activity on any of the issues here - perhaps the other people have dropped theie issues. Would you be interested in giving contributor rights to others to help add new features, or is a fork the best long term solution?

@devongovett
Copy link
Owner

Merged #11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants