Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebSocket fails on .NETFramework #11

Open
NovusTheory opened this issue Jun 20, 2018 · 2 comments
Open

WebSocket fails on .NETFramework #11

NovusTheory opened this issue Jun 20, 2018 · 2 comments
Labels
bug Something isn't working

Comments

@NovusTheory
Copy link
Collaborator

NovusTheory commented Jun 20, 2018

As per how ClientWebSocket works in .NETFramework (Microsoft's problem) the WebSocket fails to connect properly or at least will throw an exception saying the "Connection" header is invalid because Lavalink is sending Upgrade,Keep-Alive and Microsoft programmed it to only allow a connection header equal to Upgrade.

Workaround / Likely only fix => Create custom WebSocket class. EDIT: WebSocket4Net usage works too

@NovusTheory NovusTheory added the bug Something isn't working label Jun 20, 2018
@xXBuilderBXx
Copy link

This also seems to fix the issue its a modified websocket based on the original websocket class so all you have to do it replace clientwebsocket with this class and it works.
https://github.com/PingmanTools/System.Net.WebSockets.Client.Managed

@NovusTheory
Copy link
Collaborator Author

Thank you for that @xXBuilderBXx. I will look into this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants