Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper implementation of text domain while using the gettext functions #5

Closed
jmslbam opened this issue Aug 7, 2017 · 1 comment
Closed

Comments

@jmslbam
Copy link
Contributor

jmslbam commented Aug 7, 2017

printf( __('Send a new message to %s:', BBP_MESSAGES_DOMAIN);

This shouldn't be working... although it does... weird.

It should be printf( __('Send a new message to %s:', 'bbp-messages');

Explaination by Otto, core WP dev
http://ottopress.com/2012/internationalization-youre-probably-doing-it-wrong/
More info
https://ulrich.pogson.ch/string-text-domain-must

@elhardoum
Copy link
Contributor

Lesson learned. GNU gettext is not a PHP parser. Thanks man for pointing it out, I'll replace all the occurrences and push an updated, then see about your other issue and PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants