Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Interruption] if entity terminates, and then shard shuts down, entity termination is not waited #84

Closed
mattiamanzati opened this issue Jul 25, 2023 · 1 comment · Fixed by #86
Assignees

Comments

@mattiamanzati
Copy link

When an entity starts to terminate, it forks daemon the interruption effect and removes the entities from the alive set.
If shard interruption occurs and completes before that entity fully shutdown, entity termination will not complete.

Sample test written in typescript:
https://github.com/mattiamanzati/shardcake/blob/dca200d6c6c3d10a18379355cc23c74fab6338cf/test/SampleTests.ts#L292-L344

@ghostdogpr
Copy link
Collaborator

You're right, it should be waiting on the promise created earlier from terminateEntity. I will fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants