Add missing typing metadata #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathiascode
approved these changes
Jun 5, 2024
|
You're welcome! It's a weird requirement listed in PEP 561 which I have never liked. By the way when a new version with the patch is expected to be released? |
Type hints were only added in tinytag 2.0.0, which hasn't been released yet. We're using the new major version as an opportunity to add some new features and improve the API. Once #209 has been fully tested and merged, 2.0.0 should pretty much be finished. I don't have an exact release date, but the new version will be released sometime this year. |
|
Thanks! I'll wait for the new release, good luck with it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
py.typedfile and the PyPI classifier, without the former file tools likemypywill think that the library is not typed and raise errors along the line of:Skipping analyzing "tinytag": module is installed, but missing library stubs or py.typed marker [import-untyped]