Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

[Shortcuts] Support tier 3 OSs #4088

Closed
jasonLaster opened this issue Sep 19, 2017 · 1 comment · Fixed by #4102
Closed

[Shortcuts] Support tier 3 OSs #4088

jasonLaster opened this issue Sep 19, 2017 · 1 comment · Fixed by #4102

Comments

@jasonLaster
Copy link
Contributor

CCing from bugzilla Landry Breuil (:gaston)

Opening the debugger in devtools on OpenBSD triggers lots of vomit:

console.error:                                                                                                               
  Message: TypeError: KEYS[os] is undefined                                                                                      
  Stack:                                                                                                               
    getKeyForOS@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/debugger/new/debugger.js:29495:4
getKey@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/debugger/new/debugger.js:29491:11

Of course, no match for Tier3 platforms in this... :

var KEYS = {
  WINNT: {
    resume: "F8",
    pause: "F8",
    stepOver: "F10",
    stepIn: "F11",
    stepOut: "Shift+F11"
  },
  Darwin: {
    resume: "Cmd+\\",
    pause: "Cmd+\\",
    stepOver: "Cmd+'",
    stepIn: "Cmd+;",
    stepOut: "Cmd+Shift+:",
    stepOutDisplay: "Cmd+Shift+;"
  },
  Linux: {
    resume: "F8",
    pause: "F8",
    stepOver: "F10",
    stepIn: "Ctrl+F11",
    stepOut: "Ctrl+Shift+F11"
  }
};

Please, think of the kittens and take into account the BSDs or other non-Tier1 platforms (solaris ?)

@darkwing
Copy link
Contributor

Should we default getKeyFor OS to Linux if the key doesn't hit? Seems reasonable.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants