Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: CSS fix #1415

Merged
merged 4 commits into from
Oct 27, 2023
Merged

fix: CSS fix #1415

merged 4 commits into from
Oct 27, 2023

Conversation

dhananjay0601
Copy link
Contributor

@dhananjay0601 dhananjay0601 commented Oct 26, 2023 •
edited
Loading

Description

App list > Filter dropdown spacing fixtures and protection configuration background colour should be same while scrolling down which changes when it exceeds height beyond 100.

Fixes #1418

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • By refreshing the App list page and comparing the spacing between the filter dropdown and visiting the Protect configuration page checking the bg color

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@github-actions github-actions bot added the PR:Issue-verification-failed PR:Issue-verification-failed label Oct 26, 2023
@vivek-devtron vivek-devtron changed the title fix:css fix fix: CSS fix Oct 27, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dhananjay0601 dhananjay0601 changed the title fix: CSS fix feat: CSS fix Oct 27, 2023
@dhananjay0601 dhananjay0601 changed the title feat: CSS fix fix: CSS fix Oct 27, 2023
@dhananjay0601 dhananjay0601 self-assigned this Oct 27, 2023
@github-actions github-actions bot added PR:Ready-to-Review PR:Ready-to-Review and removed PR:Issue-verification-failed PR:Issue-verification-failed labels Oct 27, 2023
@dhananjay0601 dhananjay0601 merged commit f4abf7a into main Oct 27, 2023
5 of 19 checks passed
@dhananjay0601 dhananjay0601 deleted the css_fixtures branch October 27, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vivek-devtron vivek-devtron vivek-devtron approved these changes

Assignees

@dhananjay0601 dhananjay0601

Labels
PR:Ready-to-Review PR:Ready-to-Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

App list filter spacing and Protect configuration background colour
2 participants
@dhananjay0601 @vivek-devtron