Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Incorrect condition for unlocking user update api lock #3771

Closed
2 tasks done
kartik-579 opened this issue Aug 16, 2023 · 1 comment · Fixed by #3770
Closed
2 tasks done

Bug: Incorrect condition for unlocking user update api lock #3771

kartik-579 opened this issue Aug 16, 2023 · 1 comment · Fixed by #3770
Assignees
Labels
bug Something isn't working

Comments

@kartik-579
Copy link
Member

kartik-579 commented Aug 16, 2023

📜 Description

If an error is faced while updating user, the user might get stuck in lock state.

👟 Reproduction steps

  1. Update an user with surity of it facing an issue and encountering error.

👍 Expected behavior

The user should be available to be updated again.

👎 Actual Behavior

The user gets stuck in locked state.

☸ Kubernetes version

1.24

Cloud provider

🌍 Browser

Chrome

🧱 Your Environment

No response

✅ Proposed Solution

No response

👀 Have you spent some time to check if this issue has been raised before?

  • I checked and didn't find any similar issue

🏢 Have you read the Code of Conduct?

AB#5011

@kartik-579
Copy link
Member Author

RCA: In #3760, the unlock condition was being called at the end of function but in case of some error in the actual flow, unlock won't be happening causing the user to get stuck in locked state and never get updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants