Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To install in doc root or parent? #13

Closed
jerry1970 opened this issue Jul 19, 2017 · 2 comments
Closed

To install in doc root or parent? #13

jerry1970 opened this issue Jul 19, 2017 · 2 comments
Assignees
Milestone

Comments

@jerry1970
Copy link
Contributor

With a dir public I assumed the project root (with dirs app, public, and vendor) was one level above the document root. (I prefer the app outside the document root.) With a default document root public_html I made a symlink from public_html to public. Works.

But now, buildBaseUrl (in vendor/devvoh/parable/src/Http/Url.php), removing /public/index.php from $_SERVER['SCRIPT_NAME'], results in a URL starting with the domain plus /index.php/, for example:

<link rel="icon" type="image/png" href="http://mytestdomain.dev/index.php/images/icon-32.png">

Easy to change but wanted to let you know.

@devvoh
Copy link
Owner

devvoh commented Jul 19, 2017

Good find, and a use case I hadn't considered just yet!

I'll make the public_folder configurable.

@devvoh devvoh self-assigned this Jul 19, 2017
@devvoh devvoh added this to the 0.12.5 milestone Jul 19, 2017
devvoh added a commit that referenced this issue Jul 22, 2017
@devvoh
Copy link
Owner

devvoh commented Jul 22, 2017

Should be fixed in 0.12.5. Reopen if it requires fixes!

@devvoh devvoh closed this as completed Jul 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants