Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make \Parable\Http\Response HTTP/2 ready #16

Closed
FaaPz opened this issue Jul 20, 2017 · 2 comments
Closed

Make \Parable\Http\Response HTTP/2 ready #16

FaaPz opened this issue Jul 20, 2017 · 2 comments
Assignees
Labels
Milestone

Comments

@FaaPz
Copy link

FaaPz commented Jul 20, 2017

My production environment uses HTTP/2, so I suggest something like this to make it future-proof:

header("{$_SERVER['SERVER_PROTOCOL']} {$this->getHttpCode()} {$this->getHttpCodeText()}");

http://php.net/manual/en/function.header.php#92305

And please do throw away that array of HTTP status codes. It's not needed, because you can use http_response_code(). http://php.net/manual/en/function.http-response-code.php#116880

@devvoh devvoh self-assigned this Jul 21, 2017
@devvoh devvoh added the bug label Jul 21, 2017
@devvoh devvoh added this to the 0.12.5 milestone Jul 21, 2017
@devvoh
Copy link
Owner

devvoh commented Jul 21, 2017

Will be fixed in 0.12.5.

Not the array, though ;)

devvoh added a commit that referenced this issue Jul 22, 2017
@devvoh
Copy link
Owner

devvoh commented Jul 22, 2017

Should be fixed in 0.12.5. Reopen if it requires fixes!

@devvoh devvoh closed this as completed Jul 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants