Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev - parallelize influence_of_iknots #57

Merged
merged 31 commits into from
Jan 11, 2024
Merged

Dev - parallelize influence_of_iknots #57

merged 31 commits into from
Jan 11, 2024

Conversation

dewittpe
Copy link
Owner

@dewittpe dewittpe commented Jan 5, 2024

No description provided.

@dewittpe
add a plot.cpr_summary_cpr_cpr method
041a0bc
@dewittpe
add parrallel processing to influence_of_iknots; dev version to 0.3.0…
0a1c979 
….9002

Prior to this change influence_of_iknot used lapply and mapply and was
fine until the number of knots to assess was several hundred.  the
needed for parallel processing was made all most necessary

This change will use pbapply or parallel to allow for parallel
processing and progress bars

re #17
@dewittpe dewittpe added this to the v0.4.0 milestone Jan 5, 2024
@dewittpe dewittpe self-assigned this Jan 5, 2024
@dewittpe
Copy link
Owner Author

dewittpe commented Jan 9, 2024

This PR has turned into a lot of small changes. The big one, the parallization, has been removed as it was found to be to expensive comutationally.

@dewittpe dewittpe mentioned this pull request Jan 11, 2024
Closed
@dewittpe
Copy link
Owner Author

dewittpe commented Jan 11, 2024 •
edited

Every check is passing except for ununtu-lastest (devel). The following warnings are considered errors in the check

Found the following significant warnings:
  /home/runner/work/_temp/Library/Rcpp/include/Rcpp/iostream/Rstreambuf.h:53:20: warning: field precision specifier ‘.*’ expects argument of type ‘int’, but argument 2 has type ‘std::streamsize’ {aka ‘long int’} [-Wformat=]
  /home/runner/work/_temp/Library/Rcpp/include/Rcpp/iostream/Rstreambuf.h:57:21: warning: field precision specifier ‘.*’ expects argument of type ‘int’, but argument 2 has type ‘std::streamsize’ {aka ‘long int’} [-Wformat=]
  /home/runner/work/_temp/Library/Rcpp/include/Rcpp/print.h:30:19: warning: format not a string literal and no format arguments [-Wformat-security]
See ‘/home/runner/work/cpr/cpr/check/cpr.Rcheck/00install.out’ for details.

This error is not something that I can control in my package code.

@dewittpe dewittpe merged commit c175fa3 into master Jan 11, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dewittpe dewittpe

Labels
None yet
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@dewittpe