Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Balance checks in ERC223_token.sol #45

Closed
TovarishFin opened this issue Apr 29, 2018 · 2 comments
Closed

Balance checks in ERC223_token.sol #45

TovarishFin opened this issue Apr 29, 2018 · 2 comments

Comments

@TovarishFin
Copy link

Are the balance checks in the various transfer functions actually needed? Shouldn't the safe math functions catch these issues?

@Dexaran
Copy link
Owner

Dexaran commented May 14, 2018

As you can see there are no balance checks currently https://github.com/Dexaran/ERC223-token-standard/blob/master/token/ERC223/ERC223_token.sol#L36-L37

@TovarishFin
Copy link
Author

Sorry must have been looking at a different version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants