Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAML verifyResponseSig dereferences nil pointer #1823

Open
jaym opened this issue Oct 5, 2020 · 0 comments
Open

SAML verifyResponseSig dereferences nil pointer #1823

jaym opened this issue Oct 5, 2020 · 0 comments

Comments

@jaym
Copy link

jaym commented Oct 5, 2020

The code

	assertion, err := etreeutils.NSSelectOne(response, "urn:oasis:names:tc:SAML:2.0:assertion", "Assertion")
	if err != nil {
		return nil, false, fmt.Errorf("response does not contain an Assertion element")
	}

seems to leave assertion nil when when an element is not found instead of returning an error, causing a panic when it is later used.

I think the errors in #1757 were this panic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant