-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to create a secret when using the Google connector. #23
Comments
Honestly, it feels like something that the user should do before installing the chart. You can have multiple google connectors configured in a single Dex instance, so there is no clean and generic way to do it in the chart (at least one that I see). |
The primary reason I see for including the secret in the helm chart and not shipped separately is to be able to SOPS encrypt it. IE @sagikazarmark What about an Example extraSecrets and extraManifests implementations. extraSecrets:
- name: dex-google-serviceAccount-credentials
type: Opaque
data:
project1.json: |
SuperSecetJSONCredentials
project2.json: |
MoreSuperSecetJSONCredentials
- name: dex-google-serviceAccount-credentials-differentSecret
type: Opaque
data:
project3.json: |
differentSuperSecetJSONCredentials volumes:
- name: google-serviceAccount-credentials
secret:
secretName: dex-google-serviceAccount-credentials
- name: google-serviceAccount-credentials-differentSecret
secret:
secretName: dex-google-serviceAccount-credentials-differentSecret
volumeMounts:
- name: google-serviceAccount-credentials
readOnly: true
mountPath: /tmp/google-serviceAccount-credentials
- name: google-serviceAccount-credentials-differentSecret
readOnly: true
mountPath: /tmp/google-serviceAccount-credentials-differentCredentials
config:
connectors:
- type: google
config:
serviceAccountFilePath: /tmp/google-serviceAccount-credentials/project1.json
- type: google
config:
serviceAccountFilePath: /tmp/google-serviceAccount-credentials/project2.json
- type: google
config:
serviceAccountFilePath: /tmp/google-serviceAccount-credentials-differentSecret/project3.json |
When using the Google connector you have to set the
serviceAccountFilePath
in the config. When installing inside the cluster this will have to exists in a secret that we can mount. It would be great if there is an option in the helm chart for this instead of having to create it before using the helm chart.Does this seem like a reasonable request? If so I could probably send in a PR for it.
The text was updated successfully, but these errors were encountered: