add service.loadBalancerIP

[kingsmill]

Preflight Checklist

• I agree to follow the Code of Conduct that this project adheres to.
• I have searched the issue tracker for an issue that matches the one I want to file, without success.

Problem Description

This helm chart supports setting "service.type" but if you define the service.type to LoadBalancer the helm chart does not have the option to set "service.loadBalancerIP" which is required to define a dex service external IP for direct remote access.

Proposed Solution

This would be a simple change. The following three lines would be required in templates/service.yaml.

spec:
  type: {{ .Values.service.type }}
  {{- with .Values.service.clusterIP }}
  clusterIP: {{ . }}
  {{- end }}
  {{- with .Values.service.loadBalancerIP }}    <--
  loadBalancerIP: {{ . }}                       <--
  {{- end }}                                    <--
  ports:

Alternatives Considered

Modify helm chart or use another helm chart. By way of comparison, some other dex helm charts do support loadBalancerIP.

Additional Information

No response

[sagikazarmark]

@kingsmill thanks for opening this issue.

Yeah, adding loadBalancerIP make sense. Feel free to submit a PR if you are in the mood for it.

Thanks!

[DonaldKellett]

I second this, would be great if we could specify a static load balancer IP address