Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the option to store the config as ConfigMap #83

Open
2 tasks done
mheuser opened this issue May 3, 2022 · 0 comments · May be fixed by #84
Open
2 tasks done

Add the option to store the config as ConfigMap #83

mheuser opened this issue May 3, 2022 · 0 comments · May be fixed by #84

Comments

@mheuser
Copy link

mheuser commented May 3, 2022

Preflight Checklist

  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for an issue that matches the one I want to file, without success.

Problem Description

I want to be able to use a ConfigMap instead of a Secret for storing the config. Dex makes it possible to not need actual secrets in the config. We can use env vars for that as seen in the Dex GitHub example.

This makes it easier (at least for me) to integrate this chart into e.g. external-secrets, jenkins x, hashicorp vault and similar.

Proposed Solution

Add an field configType with secret set as default - so no breaking change - and configMap as option. Handling of the ConfigMap analogue to the Secret handling.

Alternatives Considered

Subcharting this Chart. Since there is no option to not reference the secret in the volumes section of the deployment this is not possible.

Additional Information

No response

@mheuser mheuser linked a pull request May 3, 2022 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant