Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to create a suffix pattern for sitemaps. #12

Open
anellimarla opened this issue Aug 27, 2015 · 1 comment
Open

Unable to create a suffix pattern for sitemaps. #12

anellimarla opened this issue Aug 27, 2015 · 1 comment

Comments

@anellimarla
Copy link

Hi,

While using your library, I noticed there was no way to specify a suffix ( custom numbering per say ) and we have to rely on the the rule that the code automatically appends a number ( sitemap1.xml) when the number of urls exceed a certain max. In the sitemaoGeneratorOptions, just like you have an option to specify a suffix, if we have a way to add a special string pattern suffix which can be customized per need and suffices can be turned on or off using a flag, it serves the purpose a bit better for how you want the numbering to work for sitemaps.

I cloned your repo, and made the change locally, and then tried to push my branch to your repo, so I can submit a PR, but I run into permissions issue. Please let me know what is the right way to approach this, or grant permissions to submit PR, so you can review the change I am proposing.

A quick response is highly appreciated!
Thanks a bunch!
Ankita.

@dfabulich
Copy link
Owner

No permissions are required to submit a PR; several folks have done it already without issue. It's possible that instead of trying to push to your own fork, you're trying to push directly to the dfabulich/sitemapgen4j repo, which isn't allowed.

Instead, you push to your own anellimarla/sitemapgen4j fork, and then create a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants