Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ic-utils to not require Send for candid::Type #449

Open
chenyan-dfinity opened this issue Jul 3, 2023 · 2 comments
Open

Refactor ic-utils to not require Send for candid::Type #449

chenyan-dfinity opened this issue Jul 3, 2023 · 2 comments

Comments

@chenyan-dfinity
Copy link
Contributor

Currently, ic-utils's update/query builder requires candid::Type to have Send trait, due to the imprecise scoping of async. Some refactoring is needed to make the async scope more precise. As a workaround, #448 adds Arc around candid::Type, but there is a significant slowdown in deserialization.
@chenyan-dfinity chenyan-dfinity mentioned this issue Jul 3, 2023
Merged
3 tasks
@dfx-json
Copy link
Contributor

dfx-json commented Aug 7, 2023

@chenyan-dfinity can this issue be closed?

@chenyan-dfinity
Copy link
Contributor Author

Sure, once we make a new release for ic-utils.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chenyan-dfinity @dfx-json